Tobias Munk

Results 508 comments of Tobias Munk

How about starting with the approval of the workflow-action :) ?

FYI: we were able to build it on PHP 8.3 for `amd64`, but not `arm64` ``` #52 2615.4 In /tmp/pear/temp/imagick/Imagick.stub.php: #52 2615.4 Unterminated preprocessor conditions #52 2615.4 make: *** [Makefile:196:...

I thought about a PR which enables you to use it on top of different systems via Docker. Would that be OK? Won't be able to do it soon, but...

LGTM. @germanbisurgi Please have a look!

*Ideally* we create tests for https://github.com/json-editor/json-editor/issues/1383, https://github.com/json-editor/json-editor/issues/1384 -- which fail (`@optional`) And this PR fixes them.

@germanbisurgi Please merge, unless you think something is still needed.

@derekisbusy I also agree to @uldisn, you should implement the dbConnection in the model as described in the Yii guide. You can specify a base class in the **model generator**...

Ping... We're seeing breaks again: https://github.com/yiisoft/yii2-docker/actions/runs/3654098169/jobs/6174221320

Current constraint is a bit overly strict.

> AFAIK `preg_split()` returns `false` only if you pass invalid input or regex. In `countWords()` regex is hardcoded, so input must be a problem - for what value (and what...