Manuel Schmidt

Results 8 comments of Manuel Schmidt

> LGTM Well, unfortunately most of my tests still fail. My feeling is that we should do this when there is at least one other person that has problems with...

@krassowski that sounds familiar to me. Only that I have polluted the tests on the main repo (sorry) ... so let's get on with this. 1) the commit a7f5c5d should...

> in your screencast with font diff, was the test ran twice? If so was the diff identical in the two attempts? Just re-ran it twice manually. Yes they are...

> But I'm a bit afraid of using higher threshold (the [default seems to be 0.2](https://github.com/microsoft/playwright/blob/5ba7903ba098586a13745e0d7ac894f1d55d47aa/packages/playwright-test/src/matchers/golden.ts#L69)). Yes, I know what you mean. But with many of my tests failing with...

@fcollonval can you please check `fc-list | grep 'Menlo\|Consolas'`

Another observation: ![completer](https://user-images.githubusercontent.com/74381262/146504466-431e1e39-2a51-458d-acf5-0e4640c66c8a.gif) Shouldn't the result be like "actual", rather than "expected"?

How shall we proceed here? For me this PR makes testing a little easier. But I haven't managed to get the italics issue under control. So it would be interesting...

Thanks, guys, for your comments. My experimenting so far went like this: I can send the subs associated with creating a simple order. It does not reply with an error...