Alain Schlesser
Alain Schlesser
Right now, the UI for the LHCI server allows comparisons only for the same URL across different commits. I'm currently working on the AMP for WordPress plugin, and we have...
In https://github.com/ampproject/amp-toolbox/pull/1248, we've skipped adding the AMP runtime preload(s) when the boilerplate had already been removed. However, the linter still requires the runtime preload to be present unconditionally in https://github.com/ampproject/amp-toolbox/blob/main/packages/linter/src/rules/RuntimeIsPreloaded.ts....
The linter currently doesn't use a separate recommendation for ESM preloads: https://github.com/ampproject/amp-toolbox/blob/153d76b722906aec1cb4a6c65d88f0c4d418630d/packages/linter/src/rules/RuntimeIsPreloaded.ts#L13 This is misleading, and might even lead to frustration if users blindly apply the recommendation and it doesn't...
The `runtime-host` meta tag does not seem to be tested at all, as all the tests use a relative `ampUrlPrefix` and thus throw an exception in the related code. https://github.com/ampproject/amp-toolbox/blob/3ec7bd40f34adbc8be66f951edfa6d91d5794c01/packages/optimizer/lib/transformers/RewriteAmpUrls.js#L116-L120...
Shouldn't the following logic include the render-delaying extensions (`amp-experiment`, `amp-story`, `amp-dynamic-css-classes`) to add as preloads as well? https://github.com/ampproject/amp-toolbox/blob/bf92d77fd1f53c54519bf8bed2be05b0bca26004/packages/optimizer/lib/transformers/RewriteAmpUrls.js#L174-L176 According to item 3. of the `Optimize your hosted AMP pages` guide:...
The rewritten AMP URLs only contain `preload` tags. However, some browsers do not support this, or only support it behind a flag that disables it by default right now. https://github.com/ampproject/amp-toolbox/blob/bf92d77fd1f53c54519bf8bed2be05b0bca26004/packages/optimizer/lib/transformers/RewriteAmpUrls.js#L163-L172...
In the following spec test, you can see that there's two CSS rules that should have been merged together but weren't: https://github.com/ampproject/amp-toolbox/blob/1cf9646b6723b4a3556356da02be190caacd1f32/packages/optimizer/spec/transformers/valid/ServerSideRendering/converts_sizes_attribute_to_css/expected_output.html#L8 A single rule `#i-amp-0,#i-amp-1{width:100vw}` should have been generated...
The `ReorderHead` transformer puts the resource hints at the back of the head (see entry `(8)`): ``` // ReorderHead reorders the children of . Specifically, it // orders the like...
According to the code and comments, the order between linked stylesheets and the amp-custom style should be preserved, which makes sense, as you'd want to keep CSS ordering intact. However,...
In several of the `ReorderHeadTransformer` spec tests, there's a `` tag that gets reordered as well. My tests in PHP are currently failing on these, and I think they are...