Alain Schlesser
Alain Schlesser
The extensible class `AMP_Base_Sanitizer` has a private property `$should_not_removed_nodes` [sic]. It is being used in a public method `remove_invalid_child()`, and if an extending class would override this public method, for...
## Feature description I think it would be valuable to have a single test that runs a big chunk of HTML through the sanitizer which contains at least 1 validation...
Once https://github.com/GoogleChrome/web-vitals/pull/323 is merged and in a tagged release, we should move away from hard-coding thresholds in the plugin and instead reuse the exported thresholds directly. This ensures we wont...
Split class out into a separate file so that it can be properly managed through Composer autoloading. This enables other code (which is not using the procedural access to the...
The class `Spyc` should be split out into a separate file so that it can be properly managed through Composer autoloading. This enables other code (which is not using the...
Hey Sean, Just a friendly ping from the WordCamp Brighton audience, that is still waiting for you to commit your code... ;) Cheers, Alain
The "tilde to HOME" replacement seems incorrect: https://github.com/webmozart/path-util/blob/d939f7edc24c9a1bb9c0dee5cb05d8e859490725/src/Path.php#L97 If you are `user_a` and you type `~user_b`, this would be replaced by the shell to mean `/home/user_b`. The current code will...
The plugin will also activate previously deactivated plugins if the endpoint matches (replacing the list of active plugins), not a whitelist (filter the list of already active plugins). Is that...
Components that contain a slash in their name, like `Bootstrap/Load`, are currently broken. The component name is passed unescaped into the URL, resulting in a presumed hierarchical relation: The component...
The following line throws a fatal error in PHP 7.4+: https://github.com/xwp/block-scaffolding-wp/blob/412029a0be0f9b08468c195a985a2c4131415ffc/php/Plugin.php#L172  As can be seen in the [documentation for `get_file_data()`](https://developer.wordpress.org/reference/functions/get_file_data/), the second argument...