Simon Chen

Results 6 comments of Simon Chen

@ormsbee We found the tracking logs are sent to Segment app on edX side. Because of that, we can quickly verify this PR on stage and prod. Once you feel...

@ormsbee OK, So I made a mistake conceptually. I thought the logs sent to segment app is the same as tracking logs. This is not the case. Tracking logs are...

@e0d I asked @ormsbee to help me validate if the code in this change would touch segment tracking events as well. That said, I also wanted to get 2U SRE...

@e0d I am planning to merge this PR and validate on stage Monday, Nov 14th. 2022

@firasalkafri This isn't a good place to get help. you should take a look at https://open.edx.org/getting-help. Just to give you a little help here, please note in https://github.com/edx/ecommerce/tree/master/ecommerce/extensions/api/v2/views/courses.py#L87, you got...

@aht007 Reviewed your devstack PR as well as re-review on this one. Still LGTM. Feel free to merge.