Jens Schauder
Jens Schauder
The PR as it stands right now, is not acceptable. It will not throw an `OptimisticLockingException` in the case of concurrent modification. It is not about avoiding optimistic locking exceptions....
Thanks for the additional test. There is still one scenario to investigate though. What happens in the old and new version of the code when the entity (without optimistic locking)...
I'm very much against changing anything about the observed behaviour in this. While I agree that a lot of it is weird, there are going to be people relying on...
> OK, should I update commits to only keep the first one? I'm not sure I understand the intention with this one. We need either full support by integration tests,...
But it does not test what happens, when you delete a managed dirty entity.
In this scenario the interesting case is not for versioned entities, but for unversioned. There is a risk that they get flushed to the database triggering life cycle events, database...
No, we need a test mitigating that risk.
Thanks for looking into this. I don't think though that we can accept a fix that duplicates code like this. And that shouldn't be necessary, since in general the conversion...
There is a RC: https://mvnrepository.com/artifact/org.springframework.data/spring-data-envers?repo=springio-milestone The Spring Data Envers source code was moved to the Spring Data JPA repository for 3.0: https://github.com/spring-projects/spring-data-jpa/tree/main/spring-data-envers
I still need a minimal reproducer, to clear up the confusion.