spring-data-envers icon indicating copy to clipboard operation
spring-data-envers copied to clipboard

spring-data-envers pulls in various javax and JBoss spec jars when their jakarta.* equivalents are preferred

Open wilkinsona opened this issue 3 years ago • 3 comments

We had an initiative a few years ago across the Spring portfolio to consistently use jakarta.* spec jars. spring-data-envers has got out of step with this, pulling in the following:

  • javax.activation:javax.activation-api
  • javax.persistence:javax.persistence-api
  • javax.xml.bind:jaxb-api
  • org.jboss.spec.javax.transaction:jboss-transaction-api_1.2_spec

Could these please be excluded and their Jakarta equivalents depended upon instead?

wilkinsona avatar Nov 12 '21 21:11 wilkinsona

I guess it's related to the upcoming Spring / Spring Boot 3.0 release that will use Hibernate 6.1.5+ (see https://github.com/spring-projects/spring-boot/releases/tag/v3.0.0-RC2). And there is still no 3.0.0 RC for spring-hibernate-envers (at least I don't set it here on https://github.com/spring-projects/spring-data-envers/releases). hibernate-envers:6.1.5.Final exists, see https://mvnrepository.com/artifact/org.hibernate.orm/hibernate-envers/6.1.5.Final.

dmitry-weirdo avatar Nov 14 '22 14:11 dmitry-weirdo

There is a RC: https://mvnrepository.com/artifact/org.springframework.data/spring-data-envers?repo=springio-milestone

The Spring Data Envers source code was moved to the Spring Data JPA repository for 3.0: https://github.com/spring-projects/spring-data-jpa/tree/main/spring-data-envers

schauder avatar Nov 14 '22 14:11 schauder

I guess it's related to the upcoming Spring / Spring Boot 3.0 release

This request isn't related to Spring Boot 3.0, in fact I think the upgrade to Jakarta EE 9/10 has taken care of things already. This issue applies to Jakarta EE 8 where there are both JBoss spec jars and official spec jars and consistent use of the official spec jars would help to avoid duplicate classes on people's classpaths.

wilkinsona avatar Nov 14 '22 14:11 wilkinsona