Sammy Chang comments

Results 17 comments of


Sammy Chang

Does Zofia counter Echo?

Should be the other way around I think. "Does Zofia counter Echo('s Yokai concussion)?"

The "Import Data", "Premium Membership", "Subscription" and "Edit User" pages contain strings that cannot be translated

Is anyone actively working on this? Planning on working on it if not. Edit: I'm seeing the issue still there for the above-mentioned locations.

The "Import Data", "Premium Membership", "Subscription" and "Edit User" pages contain strings that cannot be translated

Cool, I hope it's good with others. I am making progress on this, and I'll keep the thread updated :)

The "Import Data", "Premium Membership", "Subscription" and "Edit User" pages contain strings that cannot be translated

A bit blocked on using Crowdin/getting translations and the "Status" options. ## Crowdin stuff: I'm not too familiar with Crowdin and the workflow to get translations in for it. I've...

[PS-1465] Fix #2806 - The "Import Data", "Premium Membership", "Subscription" and "Edit User" pages contain strings that cannot be translated

I reverted my changes to the Finnish `messages.json`. I'm down to separate the work for `user-add-edit.component.ts` and accompanying `messages.json` from the import file input selector work. Makes more sense in...

[PS-1465] Fix #2806 - The "Import Data", "Premium Membership", "Subscription" and "Edit User" pages contain strings that cannot be translated

Ah gotcha, sorry if I misunderstood. Edit: Updated this fork/branch with `master` and the description on the PR.

[PS-1465] Fix #2806 - The "Import Data", "Premium Membership", "Subscription" and "Edit User" pages contain strings that cannot be translated

Yep, I'll update the PR screenshots with an image of the page in Dark mode theme and update the PR title.

[PS-1465] Fix #2806 - The "Import Data", "Premium Membership", "Subscription" and "Edit User" pages contain strings that cannot be translated

😅 I'm done finagling with the title. Forgot for a sec GitHub tracks all title updates :(

[PS-1465] Fix #2806 - The "Import Data", "Premium Membership", "Subscription" and "Edit User" pages contain strings that cannot be translated

Sure, I'll take a look at why that might happen. 👍 Edit: Looks like the button was being assumed to be `type='submit'`, specifying the file selector's button type to 'button'...