scentini

Results 33 comments of scentini

I'm not familiar with bzlmod, in case we're doing something silly here it's not obvious to me. @Wyverald could you PTAL?

cc @meteorcloudy

We ran into issues using Bazel's [`compatible_with`](https://bazel.build/reference/be/common-definitions#common.compatible_with); we currently need to set many `compatible_with` to `cargo_build_script` targets although they are not supposed to be built in target configuration. We don't...

Hey @UebelAndre, I tried to address your comment above - we are forced to use [`compatible_with`](https://bazel.build/reference/be/common-definitions#common.compatible_with) on many `cargo_build_script` targets although they are not supposed to be relevant to `target`...

Sorry for the delayed response! Unfortunately I couldn't find much documentation of `compatible_with`, except that the underlying mechanism is not documented: https://github.com/bazelbuild/bazel/issues/10849. Looks like it might be on its way...

I think `rust_binary` shouldn't provide a `CrateInfo`, but one should still be able to depend on a `rust_binary` from `rust_test.crate`. So we could instead provide a [`TestCrateInfo`](https://github.com/bazelbuild/rules_rust/blob/21eed19188c0359d72f9a508a0c0e7040ff20070/rust/private/providers.bzl#L111), like we now...

@keith I meant also for the regular `crate_type = "bin"` `rust_binary` targets. I have https://github.com/bazelbuild/rules_rust/pull/1339 which is close to ready for review and should resolve this.

Hey @neilisaac, this PR looks good to me, however looks like CI is complaining about `.rs` file formatting, could you please fix it?

I think `cc_library` -> `rust_static_library` is a valid dependency, and as such we want to emit `CcInfo` for `rust_static_library`. The `rust_static_library` workaround you mentioned above should still be valid. Is...