sc-illiakovalenko

Results 8 comments of sc-illiakovalenko

@EvtK I checked issue with lazy loading using our Angular sample. My steps to reproduce: 1. Added lines to `src/tsconfig.app.json`: ``` "paths": { "@angular/*": ["../node_modules/@angular/*"], "rxjs": ["node_modules/rxjs", "../node_modules/rxjs"], "@myrepo/shared/jss-components": ["app/components/shared-components.ts"]...

@EvtK What about such proposal? Define `tsconfig.app.json`: ``` "paths": { "@angular/*": ["../node_modules/@angular/*"], "rxjs": ["node_modules/rxjs", "../node_modules/rxjs"], "@myrepo/shared/jss-components/*": ["app/components/*"] } ``` And define inside `app-components.module.ts`: ``` loadChildren: () => import('@myrepo/shared/jss-components/styleguide-angular-lazy-loading/styleguide-angular-lazy-loading.module').then(m => m.StyleguideAngularLazyLoadingModule)...

@jlast Can you remove changes related to code formatting? Seems that some formatter is installed in your workspace. It's hard to analyse your changes.

@jlast Please, check again, build is failed

@jlast But you still have a lot of changes related to code formatting In the last commit you added it. Please, revert it - carefully

@jlast No problem 😄 Please, revert your formatting changes in, check it packages/sitecore-jss-angular/src/components/placeholder.component.ts packages/sitecore-jss-angular/src/components/render-component.component.ts packages/sitecore-jss-angular/src/jss-component-factory.service.ts

@jlast For example ![image](https://user-images.githubusercontent.com/55081915/87163089-7e3a7300-c2cf-11ea-8e06-67f37b87fd30.png)

@jlast I want to ask you, switch target branch to: release/15.0.0. And pull it