sbulen

OK, after running this on my site for a while, I think there are two issues with it: 1. It should delete, not mark unread. The alerts themselves point to...

Change made.

Found another tweak needed while testing... $user_info isn't populated when this is invoked via cron, so don't use it...

> It seems like setting the new value again further down in updateMemberData() is redundant, since we just did it in alert_count(). Is there something I am missing here, or...

Is this a dupe of #7389?

> I don't think the rest of the differences you describe are a concern. Agreed. Just documenting for awareness. I hadn't noticed those differences before myself.

The thing is that it tries to delete them. But that's failing somehow.

Added one more.... smf_package_servers validation_url - whether the column is nullable is different between install & upgrade.

Yep. Until recently(-ish), those label columns were being successfully deleted. After a change, the deletion doesn't work. It's safe to make the delete work again.

Feels like we're overthinking this... We delete many old unused cols via the upgrader. In this case, the upgrader used to delete these cols. A somewhat recent change broke that....