sbulen

Results 157 comments of sbulen

> Also text fields may be affected in some circumstances. > They may require being changed to their upper tiered counterpart. > (ie. text to mediumtext) Pretty sure we're good...

> > > I see that in your changes are using utf8mb4_general_ci and I would like to propose using utf8mb4_unicode_ci. > "general" does not use the unicode rules for sorting...

& THANK YOU for the feedback. I think this is an important topic.

> > > As per my other comments on this. This is a big change in how we handle the database layer. As such its too late in 2.1 to...

It's marked as a draft because the dev team had agreed to wait until after 2.1 goes live for mb4 support. I want to ensure it doesnt get merged prematurely.

I brought this current, in case folks wanted to test. I incorporated most feedback above. This required a rebase due to many layers of conflicts. I have not yet responded...

I haven't seen any issues with pg yet. Still early in testing, though.

> > > Whst is with "Convert HTML-entities to UTF-8 characters" is part of the migration or had the user run this by hisself after the mb4? It's not part...

> > > From where they know, that they had to doit? Good point. (Just like today...) This would be a good thing to add to the online wiki documentation....

Brought this one current again.