Stefan Büringer
Stefan Büringer
I took a look at testgrid (https://testgrid.k8s.io/sig-api-machinery-kubebuilder#controller-runtime-periodic-main). In general, I think we're in a good state. But we have a few flakes that we should ideally fix. ### *when context...
I think we should either implement dry-run or return errors instead of just nil if someone tryes to use dry-run with the fake client. xref: https://github.com/kubernetes-sigs/controller-runtime/blob/9893d5b1d172970b8c33ecbcf247114a434fd7df/pkg/client/fake/client.go#L913 Returning nil seems very...