Sami Boukortt

Results 26 comments of Sami Boukortt

To me, there seem to be two orthogonal questions here: the distribution (triangular or not), and the function that maps image brightness to noise amplitude. The former, we cannot change...

> I guess the main problem is this: > > ``` > ./lib/jxl/enc_color_management.cc:1076: JXL_ERROR: Failed to make RGB_0.345985;0.360691_0.711098;0.288564;0.177004;0.822111;0.158514;-0.000808_Rel_TF? usable as a color transform destination > ``` > > @sboukortt any...

After further discussion, we are considering possibly forgoing the targeting of ICC profiles altogether and only allowing target colorspaces that are describable as `JxlColorEncoding` structs. It would seem to make...

> I kind of wonder how useful JxlDecoderSetPreferredColorProfile will still be if we have a function that can guarantee to give you output in the preferred space (which would only...

Case 4 should be relatively rare, because in VarDCT mode, if the ICC profile represents a colorspace that can be expressed with enum values, the encoder currently replaces it with...

> I guess even with `CI:full` this new build doesn't get triggered, since it's part of something that only gets done on pushes to main. Shall we just try merging...

I don’t remember whether we actually wanted to. I think this might have been meant as a quick&dirty one-off to get binaries with such debug info from the CI to...

We should probably disallow the combination for now.

While native support for LUTs would allow for more flexible colour management, applying ReShade to Dolphin seems to work well enough for that.

Incidentally, it seems that GitHub has exactly the same bug, although Discord doesn’t. (It always use `*`.)