Shoubhik Bose

Results 109 comments of Shoubhik Bose

I've gone through the whole proposal and it looks like a fairly simple enhancement to the existing paradigm!

Queued for discussion at the [contributor meeting ](https://docs.google.com/document/d/1xkoFkVviB70YBzSEa4bDnu-rUZ1sIFtwKKG1Uw8XsY8)

No worries, thank you for the note. See you soon!

( sorry, this isn't a bug per se )

I would suggest the following: - If the new "incoming" CRDs don't have any breaking changes, it should be simple enough to apply the new CRDs and then install/upgrade the...

~I will go ahead and create the repo https://github.com/argoproj-labs/argocd-vault-plugin~ might not need to do that.

Ack! Thank you. Going through the project today.

Question: Instead of invoking the command, have you considered using the `"argocd.argoproj.io/refresh"` annotation? https://github.com/maruina/argocd-progressive-rollout-controller/blob/5c4ce8f6e8abc44b5edcba3385598d4a206978b0/controllers/progressiverollout_controller.go#L230 ``` func (r *ProgressiveRolloutReconciler) syncApp(app string) error { cmd := exec.Command("argocd", "app", "sync", app, "--async", "--prune")...

Questions / Could you also point out in the readme: * Which resources this controller watches apart from the ProgressiveRollout resource ? (Application, Secret?) * How should the ApplicationSet resource...

Thank you for the clarifications @maruina !