Sam Borms

That looks indeed very scary! Can you push it as a separate branch? Then I can investigate better if there are unintended consequences, before we merge it into master.

Let me put it on hold for a while. Will for sure come back to this (probably after official publication in JSS), because it is a good idea.

I think it's better to add a new weighting option than to change one which has been around for many versions and is implemented correctly. In the end it's just...

I thought the wrong ordering was fixed in this commit 6efe36742309282a35c52780ceaed6df73c8fe04, and version 0.8.2. The function as.sento_corpus() refers to sento_corpus() for the ordering. What version are you using? What is...

Alright, got it, that's good news at least! Outputs make sense. In the documentation of `compute_sentiment()` as part of the `tokens` argument there is already this: "... Make sure the...

Sounds good. I prefer the first option, it’s the least invasive one, although the second one is a bit safer. Feel free to adapt and file a pull request, otherwise...

Nice addition, well documented & good unit test! Some feedback: - Prefer to change `remove_elisions` to `do.removeElisions` (consistent with naming of logicals, cf. `do.ignoreZeros`). - Because you're not sure about...