Samuel Benzaquen

Results 13 comments of Samuel Benzaquen

Just to update. It seems that the standard libraries use `const_cast` where necessary to cast away the constness of keys when implementing map/unordered_map. At least libstc++ and libc++ do. Doing...

std needs mutable access to the key to implement `node_handle::key()`. They do it through `const_cast`.

It is unlikely that `flat_hash_map` can take advantage of this API effectively. It does not have much flexibility in allocation sizes, like you would for a vector/queue. It has very...

I see. It is a special allocator that will give very large allocations to begin with. I agree that it makes a lot of sense in that case. We can...

I believe this is already fixed at head. Can you confirm?

Is this only a problem in `extension_set_unittest.cc`? Or have you seen this error in non test files?

Closing since newer version no longer has this problem.

`CacheAlignedLifecycleIdGenerator` no longer exists at head. Please verify if this problem persist on some other code.

Adding extra overloads is not a good idea. If the old one is not used, then it adds dead code. If the old one is used, then it potentially adds...