Shubham Garg

Results 4 comments of Shubham Garg
trafficstars

Thanks for the review and comments, I've pushed the suggested changes. One build step is failing currently related to `prettier` formatting. I tried to run `npm run prettier-dev` but it...

Yes, pulling the latest from `master` fixed the issues. I can run the `prettier-dev` command and build checks are also passing now. Thanks a lot! :)

Hello, I've opened a PR #3024 to add a patch for this, would really appreciate any feedback and suggestions. Thanks!

Hello, I spent some time looking into this and wanted to share my observation. As OneTrust waits with `waitForElement('#onetrust-consent-sdk', 2000)` [here](https://github.com/duckduckgo/autoconsent/blob/main/lib/cmps/onetrust.ts#L44) and given `onetrust-consent-sdk` is the parent div for consent...