Shreyas Ananthan

Results 41 comments of Shreyas Ananthan

@lucbv If we revert to a single graph, won't all `initialize_connectivity` go through the same graph creation logic and end up the way you describe? @jhux2 had expressed some performance...

@jhux2 `initialize_connectivity` is called in https://github.com/Exawind/nalu-wind/blob/73cb4b961434f552b52ccd037281406ca0e247ec/src/SolverAlgorithmDriver.C#L70 which then accesses `linsys_` for the corresponding equation system https://github.com/Exawind/nalu-wind/blob/master/src/LowMachEquationSystem.C#L1016 and then calls the `build*Graph` methods. The first step would be to separate out...

@jhux2 I am not sure I understand your question. If every `linsys_` instance has the same graph instance, then once all the equation systems call `initialize()` method, the resultant graph...

@jhux2 OK. Would it not be possible by simply changing the boundary conditions in the input file to be dirichlet instead of wall function? Can you explain your motivation for...

@jhux2 if you call `buildElemToNodeGraph` for interior and `buildFaceElemToNodeGraph` for boundaries, all these should collapse into the same graph. However, can you explain what you mean by continuity/enthalpy failing? Do...

@jhux2 Thanks, I think the solution would then be to use `buildElemToNodeGraph` and `buildFaceElemToNodeGraph` for all use cases and then we will have the full connectivity for all the different...

@lucbv Yeah, that's why I was asking about the potential performance impacts. If we replace `buildEdgeToNodeGraph` with `buildElemToNodeGraph` that will increase the stencil for an internal DOF from 7 to...

@tasmith4 clang will complain if you add `override` to certain `virtual` functions that are overridden but not others. In this case, I suspect it is unhappy about `shape_fcn` and others...

@rcknaus Thanks for starting this list. I agree with deprecating Percept-based mesh adaptivity (already removed in NaluCFD/Nalu), PMR, CHT, and Flamelets stuff. It will be there in the git-history if...

@marchdf @jamelvin Please add details on the TAMS edge implementation here, so that we can track that also.