nalu-wind icon indicating copy to clipboard operation
nalu-wind copied to clipboard

Clang warnings about overridden functions

Open tasmith4 opened this issue 2 years ago • 2 comments

The nightly dashboards report several clang warnings about overridden functions in the master element code. @overfelt these warnings began to appear after #1022 merged, although I'm a little confused about why that PR caused those warnings. Can you take a look?

tasmith4 avatar Aug 31 '22 13:08 tasmith4

https://sierra-cdash.sandia.gov/index.php?project=Nalu-Wind

https://my.cdash.org/index.php?project=Nalu-Wind

tasmith4 avatar Aug 31 '22 14:08 tasmith4

@tasmith4 clang will complain if you add override to certain virtual functions that are overridden but not others. In this case, I suspect it is unhappy about shape_fcn and others that are overridden but don't have override directives. To remove warnings, you will either have to mark all overridden functions with override or remove override from the lines added in #1022

sayerhs avatar Aug 31 '22 14:08 sayerhs

Fixed by #1030. Thanks @overfelt!

tasmith4 avatar Sep 06 '22 14:09 tasmith4