sayantan sadhu
sayantan sadhu
Hey, I would like to work on this issue, can you guide me on how to proceed.
Okay no problem, let me know once you start, thank you !!
@vfdev-5 Yeah trying to look for the reason !!
@sdesrozis Should I change them in this PR only ?
Yeah sure will do that.
Probable reason why https://github.com/pytorch/ignite/blob/2eb3bcf4949821a3c894a21a781c5a34bb5545e2/tests/ignite/contrib/metrics/test_precision_recall_curve.py#L196 is passing inspite of being wrong : There is a difference is value between precision, recall, thresholds and sk_precision, sk_recall and sk_thresolds in a distributed configuration,...
@vfdev-5 @sdesrozis Hey probably the tests for the metrics in contrib/metrics/regression are fixed, can you check once.
@vfdev-5 > your [repro code example](https://github.com/pytorch/ignite/pull/2511#issuecomment-1066114980) does not reproduce the issue and does not work with DDP as there is no communication group created. Yeah, I realized this now. Also,...
@vfdev-5 @sdesrozis this was the change I was thinking about, please check once.
@vfdev-5 yeah, now I understand it better than at that time :) Also, what to do to make the tests uniform ?