sauwming

The new additional command seems to be a separate issue, so better put it in a separate PR.

Hmm.... I find some long discussions about this on the net and it seems to be more complicated than I expected. From what I read (which I haven't tested it...

Thanks for the enhancements, but it's quite complicated to be integrated as a simple sample app. Nevertheless, we'll refer our users to this project if they need an example of...

Yes, please make sure to make any PR/issue description as complete as possible, so that: - reviewers can understand and review it faster without having to read multiple posts or...

The problem with parsing non-NULL terminated input buffer has created various bugs that are not easy to catch as well as potentially created a security issue (buffer overread). So I'm...

> The current scanner expects the input string to be NULL terminated (based on the doc). Then we need to create a new API if it is to change. We...

Perhaps you can check what's the value of `acc->contact` in `acc_check_nat_addr()` before the assertion happened and why the parsing failed. https://github.com/pjsip/pjproject/blob/master/pjsip/src/pjsua-lib/pjsua_acc.c#L1789

So does it mean that you'd rather use `guid_simple`? What's the reason?

It would be great if you can include/add the unit test as well here: https://github.com/pjsip/pjproject/blob/master/pjlib-util/src/pjlib-util-test/http_client.c

I tested the provided scenario here with pjsua sample app using the latest version, with `--use-ice` and `--use-turn` and didn't manage to get the assertion. Checking the code, when the...