Saul Shanabrook

Results 286 comments of Saul Shanabrook

#16 might also be useful

@Stewori Thanks for the reference. Luckily with [`metadsl`](https://github.com/Quansight-Labs/metadsl) I only support a small subset of Python't built in annotations in type hints, so I can just special case `Iterable` for...

For reference https://github.com/python/cpython/pull/13685 was just merged that adds `get_origin` to `typing` itself and also normalizes the return type.

> Looking at the changes, that does not seem to address the issue discussed here, nor the somewhat related issue I have with getting the generic base type. Correct me...

> Okay, then "normalization" refers exactly to the opposite of what is desired in this issue. One would need a way to opt out of the normalization. Yep. Or have...

Sure I'll take a stab this. It worries me a little not to have any tests, because it is hard to know if maybe upgrading django-storages will break anything, but...

Does `url_as_attachment` get the url for a certain S3 key? I am not terribly familiar with storage backends, so I don't see exactly what this function does...

Do you need to [override the `url` method](https://github.com/gtaylor/django-athumb/blob/master/athumb/backends/s3boto.py#L260) so that S3 doesn't have to be queried for the URL? The [current `url` method](https://bitbucket.org/david/django-storages/src/c751701f596d/storages/backends/s3boto.py?at=default#cl-457), does this already when there is a...

Hm... I don't' have any experience with windows scripting. Maybe they can use the linux subsytem? https://docs.microsoft.com/en-us/windows/wsl/install-win10