Stacie W
Stacie W
I've reviewed the diff (398e2476657a761d47942936c8832ec7229291e3), checked out the code and run the tests (using `./src/test/test_bitcoin --log_level=all --run_test=wallet_transaction_tests`). As an extremely new (aspiring) contributor with limited knowledge, this all looks fine...
Nit: This line in [Observing the logs](https://github.com/bitcoin-core/bitcoin-devwiki/wiki/24.0-Release-Candidate-Testing-Guide#observing-the-logs) refers to the wrong field name: ``` The peer that is currently involved in the presync phase will have its presynced_height field set,...
You are the best for including this screen recording! I think there are two things going on here: 1. You shouldn't need to copy anything from the console. Let's move...
Hi! Thanks for filing this! This was actually mentioned by 2 people in the feedback phase, as well as the following people: - https://twitter.com/holdenjacob21/status/1578489220599271424 - https://twitter.com/RainDogDance/status/1578509189001121792 - https://twitter.com/GuyKot2/status/1578702143951101952 I have...
Thanks for the PR! I think you've honed in on an issue with the instructions that a small, but significant percentage of people are hitting. You don't need to type...
Just to be clear, you are doing something like: ``` verifySignature('DFF1D77F2A671C5F36183726DB2341BE58FEAE1DA2DECED843240F7B502BA659', 'my message', '18dd62c312a59e628f16c8134dc7df6566a233e179c4fb56b7c40a1fc56360a57c7ed6bbc9d326e508d65689d7c5f01685732201b0f788f4ee880a68637b45e1') ``` But I'm saying you only need to do: ``` verifySignature(publicKey, message, signature) ``` In fact,...
ACK 9d4cfd6c5a40cafaeed31d0102b45a7e44dc0076, reviewed diff and ran unit + functional tests I'm very new to the project but this was a great PR to review, especially after the changes that came...
ACK 5db911a369df3977c79e6d8f06ccc38551db9efb
Concept ACK. I spent quite a bit of time trying to test #26172 (my findings are documented [here](https://github.com/satsie/bitcoin-notez/blob/master/bitcoin-core-development/testing-pr-26172.md)) and can confirm the difficulty of testing it with the current state...
RE: >> ... this requires the "inverse" ... > > Ha, I did not realize this before! I am fine either way. I voted for `bitcoin-cli getnetmsgstats '["message_type"]'` because as...