saschahofmann

Results 62 comments of saschahofmann
trafficstars

@jackton1 Closed the other in favor of this. I fixed the linting errors and added another assert in the test. Ready for review IMO.

Ok. Nvm there is an issue with the o2o cloning. Will fix and test

Ok the issue only appears if I make `__duplicate_o2m_fields` call make_clone which I want to add as well. I'll do it here as well. I hoped to separate them but...

> Hello @saschahofmann! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found: > > There are currently no PEP 8 issues detected...

Two suggestions: * I would turn off the code scanner seems like it's just cluttering the diff preview hard to find the codecov prompts among all these useless suggestions *...

Yeah exactly and it's super annoying to find which lines are covered because half the file is flagged by codescanner

@jackton1 I actually discovered a few problems with cross-references. I think it boils down to this: `_create_copy_of_instance` creates and copies one_to_onefields before make_clone can replace the objects. Example: ```python class...

@jackton1 I thought about the last point some more. As I mention there we actually struggle with some recursion issues when cloning a complex tree of models. Also, as I...

After some debugging this seems to be caused by one particular view `'/cms/api/main/pages/{id}/action/{action_name}/'` that seems to be knew