Julian Rüth comments

Results 263 comments of


                                            Julian Rüth

arb_get_str() & arb_set_str() does not preserve value

Note that this is somewhat related to #391. In #391 `arb_get_str` introduces an error, here `arb_set_str` introduces an error. I wonder if both methods could be more careful when it's...

autoconfiscated build

Oh, I didn't notice that there was a cmake build already. If that's still supported, that's good enough for me I think.

Question on the real_root.c example

> Any help is appreciated, I hope this is an appropiate place to request for such. Yes, I think this is an appropriate place. It seems you are describing three...

Question on the real_root.c example

> To differentiate the problems, I installed the current version of arb (and flint,mpfr,gmp) on a different machine so that "if(arb_calc_verbose)" no longer fails. > > > I would have...

Question on the real_root.c example

Also, note that the documentation for `arb_calc.h` says: > This code should be considered experimental. So you might well have uncovered a bug here somehow.

Async widget methods deadlock due to on_msg not being called

@sonthonaxrk could you elaborate a bit on how issues like this might be worked around with greenlet?

Documentation about the ajax callback is confusing

But the provided implementation does not actually report such errors as it does not seem to be calling the callback when an error happens. Or am I missing something?

Documentation about the ajax callback is confusing

When an exception happens, the callback is not called. It would probably be better to call it than to just log to the console. I'll try to create a PR...

Documentation about the ajax callback is confusing

Reporting it to the caller with "no retry" seems most natural to me.

Escaping Issues

Thanks for the hint. Do you agree that things should be properly escaped as a default though?