saraDahanCode

Results 9 comments of saraDahanCode

We should apply a `::selection { background-color / color }` rule with a `light-dark()` switch. Dark mode selection is hard to read right now.

@bennypowers @zeroedin @marionnegp I don’t have access to the Figma file. Could you please grant me permission so I can review the colors and put together the options?

We should apply a `::selection { background-color / color }` rule with a `light-dark()` switch. Dark mode selection is hard to read right now.

@bennypowers @zeroedin @marionnegp Just to clarify before I start: should the ::selection styling be applied only to regular text on the page, or should it also cover text inside components...

We should apply a `::selection { background-color / color }` rule with a `light-dark()` switch. Dark mode selection is hard to read right now.

@zeroedin @bennypowers @marionnegp Hi, I added the definitions at the page layer, as suggested, in the base @layer of docs/styles/styles.css . However, I’m not seeing any change, and it looks...

[docs]: `<rh-code-block>`: client side highlighting and importmaps

@zeroedin Hi, Im working on this issue, could you please explain where I can see or run the documentation for this? I'm not sure where I should add the documentation...

[docs]: `<rh-code-block>`: client side highlighting and importmaps

@zeroedin Got it, so you mean I should take the change from that POC PR and open a separate PR just for it, right?

docs(web-dev-server): include prism-esm in default importmap for client highlighting

@zeroedin @bennypowers Hi, I'd be happy if you could review this PR. Thanks

docs(web-dev-server): include prism-esm in default importmap for client highlighting

@bennypowers Hi, I’ve implemented it, but once I remove the dependency on floating-ui the runtime fails and I get an error: Uncaught TypeError: Failed to resolve module specifier "@floating-ui/dom". Relative...

fix(icon): clear displayed icon when icon attribute is removed or empty

@bennypowers @zeroedin @marionnegp Hi, I'd be happy if you could review my PR.

feat(label-group): create pf-label-group element

@bennypowers Error running npm run dev (also affects npm run test) When running the dev server, three TypeScript type errors occur in tools/pfe-tools/dev-server/config.ts: cors, cacheBusterMiddleware, liveReloadTsChangesMiddleware middlewares fail due to...