Stefan Appelhoff comments

Results 644 comments of


                                            Stefan Appelhoff

write_raw_bids() accepts (and silently ignores / alters) unsuitable extension

agreed, this looks like a bug to me. I think it should "autoconvert" to FIF ... or raise an exception demanding `format` to be explicitly set to FIF.

write_raw_bids() accepts (and silently ignores / alters) unsuitable extension

> Original data is in FIF and I don't see why derivatives eg filtered raw data after picking the EEG channels shouldn't stay in FIF. Does it make sense? agreed....

Template versus True digitization data

yes, and potentially checking if points fit on a sphere ... and IF they do, send a warning that we probably deal with template data

using units in channels.tsv in read_raw_bids ?

is it just that the BIDS metadata are wrong and it's actually in V?

using units in channels.tsv in read_raw_bids ?

If units can be omitted in EDF maybe we need to add a `units` param to [`mne.io.read_raw_edf`](https://mne.tools/stable/generated/mne.io.read_raw_edf.html) and then in mne-bids pass an argument to that param, where we previously...

using units in channels.tsv in read_raw_bids ?

Yes to both of your questions (IMHO) ... default should be None. and if we overwrite, we also warn.

using units in channels.tsv in read_raw_bids ?

@agramfort can this be closed now?

Columns of scan.tsv are not accessible

I generally agree that a consistent way to access extra columns in BIDS TSV files would be a good idea (not just, but also scans.tsv) :+1:

Bipolar electrode recordings and "electrodes.tsv"

Yes, that bothers me as well. I like your proposal here: ``` name type units reference status status_description ECG ECG mV bipolar: ECG+ - ECG- good n/a ``` Perhaps we...

Bipolar electrode recordings and "electrodes.tsv"

The first part of your idea sounds reasonable to me, i.e., renaming `ECG+` and `ECG-` to `ECG` and `ECG_reference` --- and then having `ECG` in `channels.tsv` and `ECG` & `ECG_reference`...