sanmalho-git

Results 16 comments of sanmalho-git

FYI - this PR breaks sonic-mgmt QoS tests when run against T2 VoQ chassis, as now the BUFFER_QUEUE_TABLE has keys based on the system port for the front panel port...

@judyjoseph @prgeor - Our understanding is that tx_disable_channel is associated with supporting break-out mode on a port. Our linecards don't support breakout mode (discrete channel disable) - regardless of the...

@prgeor 1. In our platform, we have not implemented the capability in PMON to allow for tx_disable_per_channel yet, regardless of the module type (whether QSFP-28 or QSFP-DD) inserted. How would...

@prgeor We have now added support for tx_channel_disable on our DUTs. So, have removed the dependency of support of tx_channel_disable on platform.json. Also, while running the tx_channel_disable, we noticed inthe...

@prgeor could you please re-review this PR - it is critical for platform tests to pass successfully on Nokia chassis. @judyjoseph - FYI.

@SuvarnaMeenakshi - i will fix the merge conflict - can you please review

@SuvarnaMeenakshi @judyjoseph are you expecting the PR owners to fix the pre-commit errors - even though they are in lines of code that the PR owner didn't touch.

> To ensure changes are uniform, changes should be done here as well, where golden config db is created and removed: https://github.com/sonic-net/sonic-mgmt/blob/master/ansible/config_sonic_basedon_testbed.yml#L584 > > https://github.com/sonic-net/sonic-mgmt/blob/master/tests/test_pretest.py#L291 Thanks for pointing this out....

> @SuvarnaMeenakshi - have addressed the comments and rebased.