sanjaydemansol
sanjaydemansol
@mickmister please assign this to me.
> Discussed offline: The exclude information should be part of the subscription Hi, I got it. How should I handle this https://github.com/mattermost/mattermost-plugin-github/pull/505#discussion_r738043789? > We still have issues like when user...
> @sanjaydemansol have added few suggestions from my side. @sibasankarnayak Thanks for reviewing, We need to review the PR now, since wit was in Draft state. @dipak-demansol let's sync to...
> One suggestion to `LogDebug` when both of these are true as the same time: > > * At least one subscription was skipped due to excluded repo > *...
> @sanjaydemansol We can make the `LogDebug` task a follow up task to get this merged sooner. > > For the snippet you shared below, what is the `userNotified` used...
> ## working Points > :- Exclude Functionality is Working. :- Exclude is Not effecting to the Other Channel. :- After Exclude the xyz repo, if user Subscribe the same...
> Point 3. mentioned above ☝️ @sanjaydemansol currently it seems that users would be able to subscribe to a repo but then also subscribe to the organization with an `--exclude`...
this issue https://github.com/mattermost/mattermost-plugin-github/issues/526 is fixed in mm-494.
> @sanjaydemansol Would you like to review this? It looks like you self-requested your review and then cancelled it @mickmister , I am the author of this commit/branch. I assigned...