Sandesh Kumar
Sandesh Kumar
### Description Utilize Collector#setWeight to smartly short-circuit certain aggregation paths. Basically cases when weight#count does not returns `-1`: - when `weight#count > 0` & `weight#count == maxdocs` in segments ->...
### Describe the issue https://github.com/opensearch-project/OpenSearch/blob/main/plugins/ingest-attachment/src/test/java/org/opensearch/ingest/attachment/TikaDocTests.java#L79 This test tries to parse a bunch of different documents and asserts whether the resulting parsed content in not null/empty - that's it. ``` String...
**Is your feature request related to a problem? Please describe.** CPU profiling helps in essential development tasks to monitor resource usage, improve algorithm efficiency. Suggesting integrating [async-profiler](https://github.com/async-profiler/async-profiler) as part of...
### Description Adding documents in a single chunk in unit test to avoid multiple segments in the unit test. The following assertion was failing: ``` assertEquals(expectedCollectCount, aggregator.getCollectCount().get()); ``` The number...
Starting this thread to discuss ideas for optimizing multi-terms aggregation. Sample query: ``` { "size": 0, "aggs": { "important_terms": { "multi_terms": { "terms": [ { "field": "process.name" }, { "field":...
### Is your feature request related to a problem? Please describe OpenSearch is a vast repo with several complex internal features and requires in-depth knowledge of code bases pertaining to...
### Description Unchecked recursive call in https://github.com/opensearch-project/OpenSearch/blob/main/libs/grok/src/main/java/org/opensearch/grok/Grok.java#L183 is expensive and indeterministic. 1. Changing the approach to iterative to prevent stack overflow. 2. Adding a limit on max depth size for...
[Logging Improvement] Using lambda invocations instead of checking debug/trace isEnabled explicitly
**Is your feature request related to a problem? Please describe.** Debug and trace logging presently makes a call to isDebugEnabled()/isTraceEnabled() before computing the strings inside the debug/trace logs. This is...
#### Disclaimer ~These changes are built on top of [unmerged/in-review indexing changes](https://github.com/opensearch-project/OpenSearch/pull/15289/commits/b99c73afabc8b18c86aea533969bcf6b48b3ca5d), Reviewers kindly ignore [this](https://github.com/opensearch-project/OpenSearch/pull/15289/commits/b99c73afabc8b18c86aea533969bcf6b48b3ca5d) commit while reviewing this change. When the depending changes are merged, will remove the...