Sandesh Kumar
Sandesh Kumar
Thanks @stefanvodita, @Shradha26 for doing a thorough review of gaps with Lucene's faceting. I think that in summary, this is leaning in towards support for aggregation capabilities in Lucene out...
Probably need to find replacement classes which were replaced in later version: ``` java.lang.NoSuchMethodError: 'java.lang.String com.maxmind.db.Metadata.getDatabaseType()' ``` Putting up a `good first issue` label in case anyone wants to take...
Thanks @tigermint - I have assigned this to you. Once you are able to fix and we are able to merge your changes, I will close this PR in favor...
Thanks @MeetPatel2209 for taking a look. > It seems that until the geoip -> com.maxmind.geoip2:geoip2:4.4.0 dependency is not updated to be compatible with com.maxmind.db:maxmind-db 4.0.0, we will not be able...
[Search Triage] This seems like a good optimization, happy to assist if you need some help in improving it. I guess this should be the culprit here: https://github.com/opensearch-project/OpenSearch/blob/09bacee5fc85676e97bee6b4ad87dec35c6aa8cc/server/src/main/java/org/opensearch/search/internal/ShardSearchRequest.java#L309 and can...
Thanks @Gautam-aman for fixing this test. Can you ensure your commits are signed off correctly. This should give you context on how to: https://github.com/opensearch-project/OpenSearch/pull/20171/checks?check_run_id=57257172591
Nice catch @ajleong623 - thanks for finding & fixing it. Can you add up a quick test case as well to verify the same - before and after your change!
@ajleong623 Gentle nudge that we could make this bug fix to 3.4 if we can merge it this week.
I looked up the commit which added it: https://github.com/opensearch-project/OpenSearch/commit/2f38aeb5e25bf60897ddf87d54357abd92f14ce8#diff-2d2b27a2755fd2a1d43780adc7cda194f64673c4bc655c5a80c1c167cb5bd1e9 No other references of `slice` anywhere other than what is removed in this PR. Also, tried finding its reference in code,...
@dblock @msfroh Let's hit merge & close on this one?