Sander Van Balen

Results 75 comments of Sander Van Balen

@YanceyChiew I processed your comments. I opted for a simple `enabled` flag on the local source and I expanded the readme on it a bit. I started out with an...

> I can also understand if the manually specified directory is regarded as a fallback method. Indeed, that's how I see it. I can't think of a case where the...

@YanceyChiew oh wow, that (bug) was a stupid one. Fixed it in 867a183.

> This `} else if c.folder != "" {` blocks the first exact match of a music file with an absolute path but whose lyric placed in the user-specified lyrics...

Thank you for the clarification. I think I understand what you mean now. I believe I was not making my intentions (or assumptions sufficiently clear). My approach was to play...

Thanks, that's valuable input. Concrete proposal based on the tradeoffs mentioned above: - `local.matchMusicFilename: bool` controls whether we fall back to flat identical filename matching in the lyrics directory (option...

1. I think that could be acceptable, though mpd might be running on a remote host, in which case that feels a bit out of place so overall I prefer...

I encountered this issue as well. I expect you are already aware of the cause, but for the sake of completeness I'll say that this seems to be a regression...

I can't make any promises at the moment but I can probably make some time for it sometime this week. I'll report here if/when I get started on it. I...

Before I get started on an implementation attempt, can you confirm that conceptually it would look as follows? `Union` currently logs errors for its elements [here](https://github.com/pydantic/pydantic-core/blob/e3eff5cb8a6dae8914e3831b00c690d9dee4b740/src/serializers/type_serializers/union.rs#L102) (iff none of them...