Sander Ploegsma

Results 69 comments of Sander Ploegsma
trafficstars

Take your time! I didn't mean to rush you, but I figured you may have lost track of this PR 😉

@smcg468 I see you've been busy, nice! Since some of the CI jobs are still failing I'm going to assume that you're still working on addressing the feedback. Just make...

Well there are generics in this exercise: the `List` type has a type argument. One thing I do agree with is that the exercise could be expand on the generics...

On an unrelated note: I'm not sure why the solution stub already has the private field hard-coded. It isn't required at compile time so it might be giving too much...

I'm aiming to review this early next week, FYI 😉

Definitely! Contributions like approaches are always welcome. I'll assign this one to you 👍

Thanks for the suggestion! There is an open forum post where some other ideas for new concepts have been shared. Perhaps you could also post this there, as the forum...

Not really, although there are some graphical fixes proposed that are still open. Even so, I'd hate it when people would feel discouraged to contribute to this (or any open...

This is good feedback, but is actually a bug in the exercise itself. I checked the [reference implementation](https://github.com/exercism/java/blob/main/exercises/practice/rational-numbers/.meta/src/reference/java/Rational.java#L105) and it turns out it uses a completely different implementation compared to...