java icon indicating copy to clipboard operation
java copied to clipboard

Add maps concept

Open smcg468 opened this issue 1 year ago • 8 comments

pull request

This issue addresses #2583

  • Renamed the exercise from 'high-score' to 'arcade-high score' to avoid clashing of exercise names

  • Added 'maps' to the practises and prerequisites for the 7 exercises listed in the issue

  • Changed the prerequisites for the arcade-high-score concept exercise from what was on the elixir track which was

        "lists",
        "tuples",
        "anonymous-functions",
        "default-arguments"
    

to

       "numbers"
       "strings"
  • Could also add an howManyPlayers task to utilise the .size() method if it would help, or maybe best to keep it consistent with the elixir track.

Let me know of any changes you'd like me to make.

Reviewer Resources:

Track Policies

smcg468 avatar Dec 04 '23 18:12 smcg468

Awesome! I'll try to review this sometime this week 👍

sanderploegsma avatar Dec 04 '23 21:12 sanderploegsma

@smcg468 Are you still working on this? Leave a comment if you are, otherwise I'm going to close this due to inactivity.

sanderploegsma avatar Dec 26 '23 19:12 sanderploegsma

@smcg468 Are you still working on this? Leave a comment if you are, otherwise I'm going to close this due to inactivity.

Yes still working on this, been quite busy over Christmas but should get back to it soon

smcg468 avatar Dec 27 '23 19:12 smcg468

@smcg468 Are you still working on this? Leave a comment if you are, otherwise I'm going to close this due to inactivity.

sanderploegsma avatar Feb 21 '24 08:02 sanderploegsma

@sanderploegsma Sorry yes will get back to it this weekend

smcg468 avatar Feb 21 '24 22:02 smcg468

Take your time! I didn't mean to rush you, but I figured you may have lost track of this PR 😉

sanderploegsma avatar Feb 22 '24 08:02 sanderploegsma

Hey @smcg468! we will like to know if you need help finishing this PR! it's an interesting concept to be added to the java track, so if you are busy with work we can give you a hand with it! Thanks for your time 😃

manumafe98 avatar Apr 02 '24 20:04 manumafe98

@smcg468 I see you've been busy, nice!

Since some of the CI jobs are still failing I'm going to assume that you're still working on addressing the feedback. Just make sure to hit the 're-request review' button on this PR once you're done, so I know it's ready for another look. 😉

sanderploegsma avatar May 07 '24 06:05 sanderploegsma

hey @smcg468 do you need some help with this pr?

manumafe98 avatar Jul 12 '24 01:07 manumafe98