java
java copied to clipboard
Add maps concept
pull request
This issue addresses #2583
-
Renamed the exercise from 'high-score' to 'arcade-high score' to avoid clashing of exercise names
-
Added 'maps' to the practises and prerequisites for the 7 exercises listed in the issue
-
Changed the prerequisites for the arcade-high-score concept exercise from what was on the elixir track which was
"lists", "tuples", "anonymous-functions", "default-arguments"
to
"numbers"
"strings"
- Could also add an howManyPlayers task to utilise the .size() method if it would help, or maybe best to keep it consistent with the elixir track.
Let me know of any changes you'd like me to make.
Reviewer Resources:
Awesome! I'll try to review this sometime this week 👍
@smcg468 Are you still working on this? Leave a comment if you are, otherwise I'm going to close this due to inactivity.
@smcg468 Are you still working on this? Leave a comment if you are, otherwise I'm going to close this due to inactivity.
Yes still working on this, been quite busy over Christmas but should get back to it soon
@smcg468 Are you still working on this? Leave a comment if you are, otherwise I'm going to close this due to inactivity.
@sanderploegsma Sorry yes will get back to it this weekend
Take your time! I didn't mean to rush you, but I figured you may have lost track of this PR 😉
Hey @smcg468! we will like to know if you need help finishing this PR! it's an interesting concept to be added to the java track, so if you are busy with work we can give you a hand with it! Thanks for your time 😃
@smcg468 I see you've been busy, nice!
Since some of the CI jobs are still failing I'm going to assume that you're still working on addressing the feedback. Just make sure to hit the 're-request review' button on this PR once you're done, so I know it's ready for another look. 😉
hey @smcg468 do you need some help with this pr?