sandercm comments

Results 6 comments of


                                            sandercm

don't force copy of items into tree

My usecase is quite extreme the json reply is ~13MB so even just copying that many references felt quite slow. How would I go about benchmarking this?

don't force copy of items into tree

I agree that improving the performance of TreeItem seems like a good idea. But I'm not sure why you don't like this approach of passing the items by reference. Even...

recursively expand all child leaves.

That could work, I'm basically trying to visualize json. When I press a button I want to expand the parent aswell as all it's children. Basically call open() I think...

recursively expand all child leaves.

> > In a related note my tree could be very large and I noticed that when I have to copy it in Tree::new() during every render this would be...

don't force copy of items into tree

Hi, I haven't had time to continue working on my side projects until now but these changes are great!

Convert builtin functions return type from Option<c_int> to Result<StatusOk, StatusError>.

> Thank you for tackling this. I agree the time is right to improve how exit statuses are expressed. But we can't do it by reserving new values like `STATUS_PRESERVE_FAILURE`...