Santiago Ferreira

Results 42 comments of Santiago Ferreira

@ro0gr for this one ```js const form = create({ firstName: { scope: '#firstName' }, lastName: { scope: '#lastName' }, submit: clickable('button') }); await form.firstName.fillIn('John') await form.lastName.fillIn('Doe') await form.submit(); ``` Have...

I think having an option like that could be really useful, do you want to try to implement it? That being said, I think It would be interesting to have...

Definitely, this is a feature to implement in the page objects. Meanwhile you can do what @juanazam suggested and also things like: ``` js import { create } from 'ember-cli-page-object';...

@aquamme Composing PageObject instances doesn't do what you'll expect so it should be avoided. In order to share code among several page objects you need to use plain javascript objects...

@trisrael this looks more like a bug. For this page object definition ```js export default const EntriesPage = PageObject.create({ sortSelector: { scope: '.sortSelector', buttonIsVisible: isVisible('button') } }); ``` I would...

@trisrael Please, let us know how it goes. If it's a version issue, please post it here so other users that might have the same problem can find an answer...

@benshine we need to improve the documentation. The idea is that when you define a property on a page object using the `contains` helper, you need to indicate on which...

@danwenzel I like the suggestion! If we do this, we should deprecate `contains` first and make `includes` available. We could drop de deprecation in v2.0

@SergeAstapov @ro0gr sorry I didn't know the issue was still being in use. I was cleaning some of my old PRs/Issues and closed this one (since it is from 2018)....