Samuel Sutch comments

Results 41 comments of


                                            Samuel Sutch

Updating package verison and required Django version

Hmm. I don't think this is actually what we want, because the django-json-rpc package is actually compatible with older versions of Django.

Updating package verison and required Django version

Probably, and to be honest, I don't think many people are using the JSON-RPC "explorer" which was a feature I added for a client a long time ago, and have...

django-json-rpc should be bumped to 0.7.3 and requires django>=1.9.0

sure can you please make a pull request?

added call to authentication callback, rewrote creds extraction

Will this affect current library users who are using authentication?

no source available for mochikit.py

it's just base64 but i kind of want to remove all of that stuff anyway

allow certain errors to be handled by jsonrpc, without sending django error signal

Hey this looks good to merge but could the parameter be renamed to the possibly more-self-explanatory `JSONRPC_IGNORED_ERRORS` I can then merge this in. Thanks!

HTTP status code of errors should be configurable

Pull requests welcome. I don't have the time to write code for this right now.

Make JSON-RPC method registration/discovery either more explicit, or completely implicit.

I welcome pull requests!

Injected user credentials should be cleaned up regardless of the result of authenticate()

Cool, maybe one could write a pull request? The code path is really simple (sorry, I just don't have much time right now)

Can't do a GET with JsonRPC like : http://.../jsonrpc/app.trimTails?{...}

How common is this style of GET RPC? I don't see its support in the spec. Only 1.1 supports HTTP GET and its intended use is for idempotent, safe methods...