Samuel Stroschein

Results 262 comments of Samuel Stroschein

@opral/lix this requirement and example for reactive state came up in the github action that @NiklasBuchfink is building today: The project should not be required to be re-opened because the...

@artalar Thank you for the reply! We figured that we need multi-threading (via workers) to fulfill our state/computation management requirements. Instead of hyperoptimizing the main thread, we will likely go...

@NiklasBuchfink is the diffing so complicated? the github action provides better value if it diffs and only triggers if new lint reports come in. @janfjohannes's interim workaround to trigger the...

seeing this message https://github.com/opral/monorepo/pull/2176#issuecomment-1952860075 increases the desire for diffing even more. yes the project file changed but this PR introduces no message updates. Hence, the message provides no value

> @NiklasBuchfink Can I execute the Git commands from the Typescript file similar to the CLI? Yes, you can. Search for "node subprocess" or "node execute" @janfjohannes good workaround idea...

> multiple projects (comment must include project path/id to update the correct comment) Having the comment point to the project is a good idea! That avoids config for the user.

@NiklasBuchfink let's ignore forks then? I assume commenting still work for pull requests opened on a fork to the upstream repo?

@NiklasBuchfink should I review this? The PR is marked as draft (not ready for review)

@NiklasBuchfink have you considered showing all errors but behind an accordion https://gist.github.com/pierrejoubert73/902cc94d79424356a8d20be2b382e1ab ?

@NiklasBuchfink does forking require special logic? if you derive the link to be opened in fink with `repo.getOrigin()`, you should be good to go