samuelpmishLLNL

Results 40 comments of samuelpmishLLNL

> What version of CMake are you using? 3.20.1

> Okay, so there are two things here - the ENABLE_CUDA option is required (but at one point in time was the default, so wasn't needed) Then can you please...

Update: when configuring with an old version of CMake (3.14), CHAI does build without error: ``` $ /path/to/cmake-3.14.0/bin/cmake -DCUDA_TOOLKIT_ROOT_DIR=/usr/local/cuda -DENABLE_CUDA=ON ../ ... $ make ... [100%] Built target managed_ptr_tests [100%]...

This discrepancy was intentional (although poorly explained in the implementation) to be consistent with a theory reference document that uses lower case "u" to denote the vector of unconstrained components,...

following our discussion in yesterday's meeting, we might also consider expanding our checking of mesh and material properties to include (this list is not exhaustive): - positive Jacobian determinants at...

to clarify, I'm more interested in finding out which lines of code still are still untested in each sourcefile, rather than what changes happened in a PR.

What is the nature of the failing test? Is it segfaulting, exceeding some tolerance, or something else?

For reference, a visualization of the 3D patch test mesh is the red version below: ![patch_test_mesh](https://user-images.githubusercontent.com/61714427/186518110-09930944-a049-416d-a1c5-4a4c956f4516.gif) In contrast to the blue version which has a lot of symmetries, the red...

I believe these have all been addressed (except 5, which we will defer for now since it's an aesthetic choice).

Here's a review of what we're trying to test, some of the weird practices taking place in serac's test suite, and some suggestions on how to improve. In a nutshell,...