Samuel Karp

Results 341 comments of Samuel Karp

Rebased now that #10651 merged.

It looks like my new test is leaking a container; trying to fix that now.

Latest push should fix the issue (mixing `defer` and `t.Cleanup`).

@redcurtain > containerd version 1.7.14 > `version=v1.6.4` https://github.com/containerd/containerd/releases/tag/v1.7.22 and https://github.com/containerd/containerd/releases/tag/v1.6.36 contain the fix for this issue.

> reproduce the issue with my containerd version(1.7.14). The test is expected to fail (and can block) on versions prior to 1.7.22. The test should pass on 1.7.22.

@cpuguy83 same comment :smile: https://github.com/containerd/containerd/pull/10623#discussion_r1726172036

https://github.com/containerd/containerd/releases/tag/v1.7.21 and https://github.com/containerd/containerd/releases/tag/v1.6.36 contain the fix for this issue

You may want to open an issue [on Launchpad](https://launchpad.net/ubuntu/+source/runc) for Ubuntu's runc package.

Thanks @Rico00121. This does look like a duplicate which has been fixed in v1.7.16 / v1.6.32: - https://github.com/containerd/containerd/pull/10129 - https://github.com/containerd/containerd/pull/10130

> older containerd release branches are still on 1.1.x of libcni, which doesn't have this fix yet. AFAICT, libcni doesn't do release branches, so I don't see a way to...