Samuel Karp

Results 341 comments of Samuel Karp

@dmcgowan This seems like something we could do in transfer service?

@BruceDone Are you still planning to work on this?

@laurazard Not sure if you saw https://github.com/containerd/containerd/pull/10649#issuecomment-2327618273 but this fix doesn't seem to update the container status from running -> stopped still.

Testing with db74920d4: ``` === RUN TestIssue10589 container_linux_test.go:1597: 1. Create a sleeping container log_hook.go:47: time="2024-09-04T03:01:38.222492961Z" level=debug msg="remote introspection plugin filters" func="proxy.(*introspectionRemote).Plugins" file="/home/samuelkarp/go/src/github.com/containerd/containerd/core/introspection/proxy/remote.go:57" filters="[type==io.containerd.snapshotter.v1, id==overlayfs]" testcase=TestIssue10589 container_linux_test.go:1636: 2. Create exec1 container_linux_test.go:1661:...

I only see one place where `s.runningExecs[container]` is incremented. Where do you believe the redundant count is coming from?

nit: mind updating the PR description to remove mention of the timeout, since we no longer have that in this PR?

> Does the test case in the other draft PR #10649 useful to put in this PR itself? I think it's fine to keep them separate; simpler to deal with...

I'll look tomorrow but in the meantime you should be able to pull my PR locally and test it too. Steps would be: 1. Check out your PR and `make...

This does pass the test in https://github.com/containerd/containerd/pull/10649. I would lean toward the approach in https://github.com/containerd/containerd/pull/10651 however as it seems more straightforward to me to follow.