Samuel Dionne-Riel

Results 561 comments of Samuel Dionne-Riel

``` .../aarch64-unknown-linux-gnu-ld: yjit/target/release/libyjit.a(yjit.addr2line-284e2d20513f6235.addr2line.41ffa169558d4bc2-cgu.0.rcgu.o.rcgu.o): Relocations in generic ELF (EM: 62) .../aarch64-unknown-linux-gnu-ld: yjit/target/release/libyjit.a(yjit.addr2line-284e2d20513f6235.addr2line.41ffa169558d4bc2-cgu.0.rcgu.o.rcgu.o): Relocations in generic ELF (EM: 62) .../aarch64-unknown-linux-gnu-ld: yjit/target/release/libyjit.a(yjit.addr2line-284e2d20513f6235.addr2line.41ffa169558d4bc2-cgu.0.rcgu.o.rcgu.o): error adding symbols: file in wrong format ``` This really looks...

Just coming back quickly with how it went: it built on my end. So unless you have some other resource exhaustion (like free disk space), I believe it should build,...

The cross-compilation issue has been investigated. See #771 for a fix.

It might be the expected behaviour. Though it shouldn't *reboot*. It would get you to the login prompt on an fbcon. You might want to build `examples/hello`. It will cross-compile,...

> can it be builded in action and upload release? Not really for now. No AArch64 builders on GitHub Actions. It would require some trustable AArch64 build infra I could...

Please do not recommend running random binaries found from arbitrary forks. At least not without the proper warnings and caveats that this implies (regarding security, trust, breakage), an explanation of...

Not sure if any helpful, but IIRC setting the *build variant* to `eng` makes `adb` available at boot. (Or was it `userdebug`?) - https://source.android.com/docs/setup/build/building#choose-a-target - https://source.android.com/docs/setup/create/new-device#build-layers I'm thinking a bit...

:thinking: I don't grok the big picture enough to know how `post_process_props` ends-up used. - https://github.com/search?q=org%3ALineageOS%20%2Fpost_process_props%2F&type=code I don't see any usage that would make any keys disallowed - https://github.com/LineageOS/android_build/blob/9531801b02c499820c129fb0ef501b1c76c34550/tools/post_process_props.py#L241 -...

Speaking of `build.prop` files... I was wondering where it would be... and I don't like what I'm seeing: - https://github.com/LineageOS/android_build/blob/9531801b02c499820c129fb0ef501b1c76c34550/core/sysprop.mk#L29-L32 ~~Embedding bash snippets into a higher level build system? Who...

I don't *know*, but I believe this is the current best(?) mechanism for LineageOS: - https://review.lineageos.org/c/LineageOS/android_build/+/285808/1 - https://github.com/LineageOS/android_build/commit/24304ab838226ef2546aee95f29a8ead5004ee03 - https://github.com/search?q=path%3ABoardConfigExtra.mk&type=code So something like `source.dirs."vendor/extra"`, which can be built via a...