Samuel Colvin

Results 1016 comments of Samuel Colvin

Ye, not yet implemented. They need adding like datetime: https://github.com/samuelcolvin/rtoml/blob/ccd2c01a210bcd3b7cf0be8dbbdedab352476e32/src/lib.rs#L151-L161

See my comment https://github.com/samuelcolvin/rtoml/issues/23#issuecomment-917640979 I don't agree with this approach. If were to go with this approach we would need: * to omit `None` values from lists too * to...

This needs to be hidden behind a kwarg as I mentioned above.

I agree with @pwwang but logic for detecting a "none value" when parsing toml could wait for a separate PR.

https://github.com/toml-lang/toml/issues/30 is the discussion about this for the TOML spec. I happen to disagree with them, but that's doesn't really matter much. If we follow their suggestions we should remove...

Thanks for considering it. In the absence of tests, I'd love it if you could test [`v1.10.0a1`](https://github.com/pydantic/pydantic/releases/tag/v1.10.0a1), and let us know if you see any breaking changes?

I'm afraid I don't run windows so can't fix this directly. I suspect it's related to the path separator in the executor path. If you can fix, happy to accept...

sorry not to reply earlier. I'd be happy to accept a PR to treat a special value like `'TRUE'` or `'` as the same as `True` and just add the...

Maybe try https://github.com/wkhtmltopdf/wkhtmltopdf/issues/2591

Thanks @iamyoudi for the question and @JonasKs for the explanation. Yes, I think you've got to the bottom of why this is happening. @JonasKs your idea (or something like it)...