aiotdlib icon indicating copy to clipboard operation
aiotdlib copied to clipboard

Published 20 hours ago • verified publisher icon pylakey

Add tests?

Open samuelcolvin opened this issue 2 years ago • 2 comments

Hi, this question is quite selfish, I'd like to use this repo among others for smoke testing new pydantic releases, see https://github.com/pydantic/pydantic/discussions/4359. According to this this repo has lots of pydantic imports, hence why I came here.

Would you consider adding tests to this repo, I don't know if there's a dummy api for telegram, otherwise you could create mock endpoints for unit tests.

Do you have an existing strategy for testing?

samuelcolvin avatar Aug 22 '22 13:08 samuelcolvin

Hi, I don't have any strategy for testing yet.

Telegram needs you to be authorized to use API, so it's quite a problem to run tests automatically, in GitHub actions for example. But mock endpoints could help in this situation.

I will think about adding tests. Any PRs are welcome

pylakey avatar Aug 22 '22 21:08 pylakey

Thanks for considering it.

In the absence of tests, I'd love it if you could test v1.10.0a1, and let us know if you see any breaking changes?

samuelcolvin avatar Aug 22 '22 21:08 samuelcolvin