Samuel Colvin

Results 1016 comments of Samuel Colvin

ye makes sense. `IsUri` would be useful but I'm a bit torn about how to implement it. I don't want to duplicate the masses of URI logic from pydantic, but...

Urllib is definitely not suitable for checking urls, is easy too lenient. Simplest solution would probably be to copy the regex and logic from pydantic. We know that's widely used...

* `IsUUID` is [done](https://dirty-equals.helpmanual.io/types/other/#dirty_equals.IsUUID) * `IsIP` yes, PR welcome * `IsHash` yes, PR welcome * `IsUrl` yes, PR welcome, you'll need to make pydantic a dependency, but that's fine by...

let me know when this is ready to review.

thanks so much.

humm, can you show a full example of the errror, I'm not quite sure if this is expected. I assume you've seen [this bit of the docs](https://dirty-equals.helpmanual.io/usage/#__repr__-and-pytest-compatibility)?

Fix welcome, but the simplest fix might be to run tests with `TZ=utc ...`. If that's not an option, it shouldn't be hard to fix in python.

I think (hope) it's just that tests assume UTC.

Otherwise looking good.

conflicts too.