dirty-equals icon indicating copy to clipboard operation
dirty-equals copied to clipboard

Feat add IsHash

Open osintalex opened this issue 2 years ago • 3 comments

I've kept very simple since this is all I'd want to use to save time in tests and imagined I'd probably want to define a custom regex for most other hashes using IsStr. Just my two cents though.

osintalex avatar Jun 19 '22 20:06 osintalex

Codecov Report

Merging #44 (aa706fc) into main (5cf23ce) will not change coverage. The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          692       709   +17     
  Branches       176       180    +4     
=========================================
+ Hits           692       709   +17     
Impacted Files Coverage Δ
dirty_equals/__init__.py 100.00% <100.00%> (ø)
dirty_equals/_other.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5cf23ce...aa706fc. Read the comment docs.

codecov[bot] avatar Jun 19 '22 20:06 codecov[bot]

Otherwise looking good.

samuelcolvin avatar Jun 24 '22 11:06 samuelcolvin

Ready for review ☺️

osintalex avatar Jun 25 '22 17:06 osintalex

conflicts too.

samuelcolvin avatar Sep 02 '22 19:09 samuelcolvin

Think that's all your changes and conflicts gone, let me know if I missed anything.

osintalex avatar Sep 02 '22 19:09 osintalex

Thanks so much @osintalex, I'll make a new release now.

samuelcolvin avatar Sep 15 '22 11:09 samuelcolvin

~~I'll make a new release now~~ cancel that, I'll make a release once #47 is merged.

samuelcolvin avatar Sep 15 '22 11:09 samuelcolvin