go-thrift issues

Making typedefed maps and slices passing by value.

Current implementation generates non-compilable code if typedef defined. example: type Map1 map[int32]string this would generate different access code for parameters and return values. Return values will be return by value,...

octo47

Are we missing "default" field requiredness?

1

I've generated a few thrift clients with this lib. Working good so far. But I have an instance where I've needed to modify the generated code. It's related to the...

anxiousmodernman

Hex enum values are parsed as 0

1

``` enum Something { FOO, BAR, ON_NOES = 0xFACE // fails } ```

brandonbloom

Missing required field even though it exists

Hi, tried to use this library (after some problems with Apache's one), and ran into a problem with binary codec. I was looking at the source code and this place...

ghost

Fix return type typo for oneway method

When a function in thrift is declared as oneway, the go code generated will have the default return type 'err error', it should be wrapped with bracket.

Wuvist

Fixing maxFrameSize bug

When message is bigger then maxFrameSize then buffer need to be reset, otherwise the content will stuck there and we going to get an ErrFrameTooBig forever.

siklosid

struct & const fixes

I was getting some output that looked like ``` go const Foo = *Bar{ Baz: 1, } ``` The first commit fixes `const` to `var` and the second commit removes...

brandonbloom