go-thrift icon indicating copy to clipboard operation
go-thrift copied to clipboard

Making typedefed maps and slices passing by value.

Open octo47 opened this issue 8 years ago • 0 comments

Current implementation generates non-compilable code if typedef defined.

example:

type Map1 map[int32]string

this would generate different access code for parameters and return values. Return values will be return by value, but argumets of functions and structure fields will be pointers.

Good example of incompatible thrift is: https://github.com/osquery/osquery-python/blob/master/osquery.thrift

Trying to generate and compile produce: osquery/extensions/osquery.go:191: cannot use val (type InternalExtensionList) as type *InternalExtensionList in assignment osquery/extensions/osquery.go:203: cannot use val (type InternalOptionList) as type *InternalOptionList in assignment osquery/extensions/osquery.go:287: cannot use res.Value (type *InternalExtensionList) as type InternalExtensionList in assignment osquery/extensions/osquery.go:309: cannot use res.Value (type *InternalOptionList) as type InternalOptionList in assignment

octo47 avatar Jun 15 '16 21:06 octo47