Sam Pillsworth

Results 14 comments of Sam Pillsworth

Agreed that the build failure looks flaky. I'm going to close and reopen the PR to kick it off fresh

Hmm the test failure is `org.http4s.ember.core.TraversalSpec.Request Encoder/Parser should preserve body with a known uri` and that test is here: https://github.com/http4s/http4s/blob/d6e5f6ab0db674e857a0f4f4331655dddfc0f35a/ember-core/shared/src/test/scala/org/http4s/ember/core/TraversalSpec.scala#L82-L98 I don't see how a new header would break this...

> Yup, sorry, that's a known flake 😕 Ah, good to know thanks! Regarding the tests, also good to know! I thought I might be misunderstanding the law test. Does...

Hi hello 👋🏻 I just merged #3134, which added IO examples alongside the `F[_]` examples in a couple of places and was set to resolve this issue. That said, reading...

I volunteered myself and @valencik to attempt to write some more documentation about this! I think there's _a lot_ to potentially cover here, and I think both the concrete `IO`...

This flaked again for me: 685b9a69ec9fb08414a8f4db96473a56ee8d923c https://github.com/typelevel/cats-effect/actions/runs/5549241691/jobs/10133111966?pr=3749#step:24:3264 ``` [error] x rename itself when entering and exiting blocking region [error] blocker thread not found after reset (WorkerThreadNameSpec.scala:87) ```

oh sorry about that! thanks @armanbilge

I think I've gotten everything publicised correctly but I still can't trigger it via an mbean proxy because of the hash that gets added to the bean name here https://github.com/typelevel/cats-effect/blob/8e38eda40915c2a0979c4730378b33e04c5fe2c4/core/jvm/src/main/scala/cats/effect/unsafe/IORuntimeCompanionPlatform.scala#L269...

I'd like to investigate this one, cc @armanbilge :D

Oops sorry @armanbilge I can't officially request a review from you it seems 😅